feat(nuxt): add bad connection detection to example page #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
=======================================
Coverage 24.28% 24.28%
=======================================
Files 121 121
Lines 12883 12883
Branches 715 715
=======================================
Hits 3128 3128
Misses 9734 9734
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
s1gr1d
approved these changes
Apr 17, 2025
| const hasSentError = ref(false); | ||
| const isConnected = ref(true); | ||
| onMounted(async () => { |
There was a problem hiding this comment.
Using async callbacks here could lead to unexpected state updated when the component mounts/unmounts or it could lead to console warnings. But that's an edge-case thing and as this is just an example page I think it's perfectly fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diagnoseSdkConnectivity()function to programmatically detect possible connectivity issues sentry-javascript#15821Before:
After:
